Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contracts): escrow-v2-general-escrow-event-update #1396

Merged
merged 5 commits into from
Jan 10, 2024
Merged

feat(contracts): escrow-v2-general-escrow-event-update #1396

merged 5 commits into from
Jan 10, 2024

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Jan 8, 2024 •
edited by pr-codex bot
Loading

NEEDS REDEPLOYMENT

PR-Codex overview

Detailed summary

This PR focuses on adding new parameters to the TransactionCreated event and the createTransaction function in the Escrow contract. The notable changes include:

  • Added _transactionUri parameter to the TransactionCreated event.
  • Added _transactionUri parameter to the createTransaction function.
  • Added _asset and _deadline parameters to the TransactionCreated event.
  • Updated the emit TransactionCreated statement in the createTransaction function to include the new parameters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kemuru kemuru requested a review from jaybuidl January 8, 2024 11:46
@netlify Netlify
Copy link

netlify bot commented Jan 8, 2024 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit d803d98
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/659e7e1d6700e70008e2e1c7
😎 Deploy Preview https://deploy-preview-1396--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kemuru kemuru linked an issue Jan 8, 2024 that may be closed by this pull request
Escrow contract: tweak the event TransactionCreated #1389
Closed
jaybuidl
jaybuidl requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@jaybuidl jaybuidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

natspec

@kemuru kemuru requested a review from jaybuidl January 10, 2024 11:23
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 10, 2024

Code Climate has analyzed commit d803d98 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jaybuidl jaybuidl merged commit d803d98 into dev Jan 10, 2024
13 checks passed
@jaybuidl jaybuidl deleted the feat(contracts)/escrow-v2-general-escrow-event-update branch January 10, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaybuidl jaybuidl jaybuidl approved these changes

Assignees
No one assigned
Labels
Package: Contracts Court smart contracts Type: Enhancement ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Escrow contract: tweak the event TransactionCreated
2 participants
@kemuru @jaybuidl